Re: [PATCH v2 3/5] usb: cdc-wdm: adding usb_cdc_wdm_register subdriver support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mittwoch, 1. Februar 2012, 16:05:22 schrieb Bjørn Mork:
> @@ -578,11 +580,11 @@ static int wdm_open(struct inode *inode, struct file *file)
>                 dev_err(&desc->intf->dev, "Error autopm - %d\n", rv);
>                 goto out;
>         }
> -       intf->needs_remote_wakeup = 1;
>  
>         /* using write lock to protect desc->count */
>         mutex_lock(&desc->wlock);
>         if (!desc->count++) {
> +               desc->manage_power(intf, 1);

It makes me very nervous to see manage_power
called under a lock. Are you positively sure this cannot
deadlock?

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux