On Fri, 2012-01-27 at 20:51 +0100, José Antonio Matute wrote: > Hi all, > > This is my first post in this list and I don't know if it's the right place. > I apologize if I'm doing something incorrect. > > After testing it on my computer (Sony Vaio VPCSA). I sent a patch to > Launchpad #917952 (https://bugs.launchpad.net/ubuntu/+source/linux/+bug/917952) > that allows use the internal USB Huawei Gobi 3000 Modem. Thanks; though to submit there's a specific format that patches need to be sent in so things work smoothly. The details are here: http://www.kernel.org/doc/Documentation/SubmittingPatches But in short, you want to do the following: 1) title your mail with [PATCH] in front, and the driver next, like so: [PATCH] qcserial: add support for Huawei Gobi 3000 devices 2) Next, in the body, write a short description of the patch, which would be something like this: Add USB IDs for Huawei Gobi 3000 devices (some of which are rebranded as Sony Vaio VPCSA modems). 3) Sign off on the patch, which indicates that you have the right to submit this patch, ie that it's your original work and you're not aware of any copyright issues with it. You might also want to get the patch into stable kernels, so add a CC for it too, like so: Signed-off-by: José Antonio Matute <matutet@xxxxxxxxx> Cc: stable@xxxxxxxxxx 4) then put three dashes on the next line ("---") and hit return 5) Now, paste in the patch in "git diff" format, like the link I pasted above describes. That's pretty easy; if you're not working from git, use the following command to get the patch: diff -u [path to original file] [path to modified file] > patch.txt 6) Copy the contents of patch.txt into the mail below the "---" line. Make *SURE* you set your mail client not to wrap lines. I see your original mail here did wrap lines, and that's a bad thing, since it means nobody can automatically apply your patch. Most mail clients have a setting called "preformatted" or such which you can set before pasting your patch into the mail. So basically, the subject should be: [PATCH] qcserial: add support for Huawei Gobi 3000 devices and the body of the mail would be: Add USB IDs for Huawei Gobi 3000 devices (some of which are rebranded as Sony Vaio VPCSA modems). Signed-off-by: José Antonio Matute <matutet@xxxxxxxxx> Cc: stable@xxxxxxxxxx --- diff --git a/drivers/usb/serial/qcserial.c b/drivers/usb/serial/qcserial.c index aa9367f..8a5c87f 100644 --- a/drivers/usb/serial/qcserial.c +++ b/drivers/usb/serial/qcserial.c @@ -87,6 +87,7 @@ static const struct usb_device_id id_table[] = { {USB_DEVICE(0x05c6, 0x9204)}, /* Gobi 2000 QDL device */ {USB_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */ {USB_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000 Modem device (MC8355) */ + {USB_DEVICE(0x12d1, 0x14f1)}, /* Gobi 3000 on Sony Vaio VPCSA */ { } /* Terminating entry */ }; MODULE_DEVICE_TABLE(usb, id_table); Long explanation, simple result. But you have to submit it, not me since it's not my original patch :) Dan > They suggest me that I must sent here this patch and then: > "Once it's upstream we can cherry-pick/apply on Ubuntu kernels." > > ------------------------ drivers/usb/serial/qcserial.c ------------------------ > index b9bb247..9038ee3 100644 > @@ -79,20 +79,21 @@ static const struct usb_device_id id_table[] = { > {USB_DEVICE(0x1199, 0x9007)}, /* Sierra Wireless Gobi 2000 Modem > device (VT773) */ > {USB_DEVICE(0x1199, 0x9008)}, /* Sierra Wireless Gobi 2000 Modem > device (VT773) */ > {USB_DEVICE(0x1199, 0x9009)}, /* Sierra Wireless Gobi 2000 Modem > device (VT773) */ > {USB_DEVICE(0x1199, 0x900a)}, /* Sierra Wireless Gobi 2000 Modem > device (VT773) */ > {USB_DEVICE(0x1199, 0x9011)}, /* Sierra Wireless Gobi 2000 Modem > device (MC8305) */ > {USB_DEVICE(0x16d8, 0x8001)}, /* CMDTech Gobi 2000 QDL device (VU922) */ > {USB_DEVICE(0x16d8, 0x8002)}, /* CMDTech Gobi 2000 Modem device (VU922) */ > {USB_DEVICE(0x05c6, 0x9204)}, /* Gobi 2000 QDL device */ > {USB_DEVICE(0x05c6, 0x9205)}, /* Gobi 2000 Modem device */ > {USB_DEVICE(0x1199, 0x9013)}, /* Sierra Wireless Gobi 3000 Modem > device (MC8355) */ > + {USB_DEVICE(0x12d1, 0x14f1)}, /* Gobi 3000 on Sony Vaio VPCSA */ > { } /* Terminating entry */ > }; > MODULE_DEVICE_TABLE(usb, id_table); > > static struct usb_driver qcdriver = { > .name = "qcserial", > .probe = usb_serial_probe, > .disconnect = usb_serial_disconnect, > .id_table = id_table, > .suspend = usb_serial_suspend, > > > Best regards, > -- > Un saludo, > José Antonio Matute > Tf: 680 410 763 > matutet@xxxxxxxxx > http://www.cmaj.es > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
