Re: [PATCH v2] usb: cdc-wdm: use dedicated lock for device list to fix autoresume on open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Greg KH <greg@xxxxxxxxx> writes:
> On Wed, Jan 25, 2012 at 08:34:22PM +0100, Bjørn Mork wrote:
>> We're holding the global wdm_mutex through most of wdm_open, including
>> when it calls usb_autopm_get_interface. This call can block waiting for
>> a resume, which will need to look up the device list.  So we deadlock.
>> 
>> Fix by using a dedicated lock for the device list.
>> 
>> Signed-off-by: Bjørn Mork <bjorn@xxxxxxx>
>> ---
>> v2: A spinlock makes more sense here, as pointed out by Oliver Neukum
>
> Oliver, any objection to me applying this patch?

Please note that it requires the "usb: cdc-wdm: subdriver support"
series which I think still is under review. It should really have been
part of that series.  Sorry for not catching the bug in time.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux