Re: [PATCH] usb: cdc-wdm: use dedicated mutex for device list to fix autoresume on open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oliver@xxxxxxxxxx> writes:
> Am Mittwoch, 25. Januar 2012, 20:02:05 schrieb Bjørn Mork:
>> We're holding the global wdm_mutex through most of wdm_open, including
>> when it calls usb_autopm_get_interface. This call can block waiting for
>> a resume, which will need to look up the device list.  So we deadlock.
>> 
>> Fix by using a dedicated lock for the device list.
>
> In that case, as the common case should be a very short list and
> you never sleep, why a mutex? A spinlock would do the job.

Right you are.  Just didn't think too far when testing the
quickfix.  Will send a new version rightaway.  Just need to verify that
it actually works (of course it does, but I still like to verify...)


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux