On Wed, 25 Jan 2012, Sebastian Andrzej Siewior wrote:
> If the stream check fails then we leave ep->desc assigend but we return
> with an error code. The caller assumes the endpoint is not enabled
> (which is the case) but it can not enable it again due to this
> assigment.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> drivers/usb/gadget/dummy_hcd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/dummy_hcd.c b/drivers/usb/gadget/dummy_hcd.c
> index f897fb8..a4c4cc1 100644
> --- a/drivers/usb/gadget/dummy_hcd.c
> +++ b/drivers/usb/gadget/dummy_hcd.c
> @@ -514,7 +514,6 @@ static int dummy_enable(struct usb_ep *_ep,
> }
>
> _ep->maxpacket = max;
> - ep->desc = desc;
> if (usb_ss_max_streams(_ep->comp_desc)) {
> if (!usb_endpoint_xfer_bulk(desc)) {
> dev_err(udc_dev(dum), "Can't enable stream support on "
> @@ -523,6 +522,7 @@ static int dummy_enable(struct usb_ep *_ep,
> }
> ep->stream_en = 1;
> }
> + ep->desc = desc;
>
> dev_dbg(udc_dev(dum), "enabled %s (ep%d%s-%s) maxpacket %d stream %s\n",
> _ep->name,
Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
