Re: [PATCH v2 8/9] usb: gadget: net2280: use generic map/unmap routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 21, 2011 at 09:52:45PM -0500, Alan Stern wrote:
> On Wed, 21 Dec 2011, Felipe Balbi wrote:
> 
> > On Tue, Dec 20, 2011 at 04:39:11PM -0500, Alan Stern wrote:
> > > On Tue, 20 Dec 2011, Felipe Balbi wrote:
> > > 
> > > > > The request doesn't get mapped in the first place unless ep->dma is 
> > > > > set.  Therefore you need to test ep->dma before unmapping the request.
> > > > > 
> > > > > The same problem exists in the goku driver; I didn't look at any of the 
> > > > > others.
> > > > 
> > > > Fix this and went through all others. There were many such mistakes :-)
> > > 
> > > I fixed the net2280 version and tested it lightly with g-file-storage.  
> > > It seemed to work fine.
> > 
> > Just so you know, you can pull my generic-map-unmap branch from my k.org
> > tree, for convenience :-)
> > 
> > Thanks for testing it. Can I add your Tested-by ? (well, only after you
> > test the patch in my branch)
> 
> Can't do any testing until I return from vacation.  Since you are on 
> vacation now too, this shouldn't matter...  :-)

it's probably time to revive this thread. I will respin the patches and
send them to linux-usb in a bit.

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux