Re: [PATCH v2] drivers: usb: gadget: f_mass_storage: Use "bool" instead of "int" in fsg_module_parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 12, 2012 at 04:09:15PM -0200, Fabio Estevam wrote:
> Fix the following build warnings:
> 
>  CC [M]  drivers/usb/gadget/acm_ms.o
> drivers/usb/gadget/acm_ms.c: In function ‘__check_ro’:
> drivers/usb/gadget/acm_ms.c:119: warning: return from incompatible pointer type
> drivers/usb/gadget/acm_ms.c: In function ‘__check_removable’:
> drivers/usb/gadget/acm_ms.c:119: warning: return from incompatible pointer type
> drivers/usb/gadget/acm_ms.c: In function ‘__check_cdrom’:
> drivers/usb/gadget/acm_ms.c:119: warning: return from incompatible pointer type
> drivers/usb/gadget/acm_ms.c: In function ‘__check_nofua’:
> drivers/usb/gadget/acm_ms.c:119: warning: return from incompatible pointer type
> drivers/usb/gadget/acm_ms.c: In function ‘__check_stall’:
> drivers/usb/gadget/acm_ms.c:119: warning: return from incompatible pointer type
>   CC [M]  drivers/usb/gadget/mass_storage.o
> drivers/usb/gadget/mass_storage.c: In function ‘__check_ro’:
> drivers/usb/gadget/mass_storage.c:94: warning: return from incompatible pointer type
> drivers/usb/gadget/mass_storage.c: In function ‘__check_removable’:
> drivers/usb/gadget/mass_storage.c:94: warning: return from incompatible pointer type
> drivers/usb/gadget/mass_storage.c: In function ‘__check_cdrom’:
> drivers/usb/gadget/mass_storage.c:94: warning: return from incompatible pointer type
> drivers/usb/gadget/mass_storage.c: In function ‘__check_nofua’:
> drivers/usb/gadget/mass_storage.c:94: warning: return from incompatible pointer type
> drivers/usb/gadget/mass_storage.c: In function ‘__check_stall’:
> drivers/usb/gadget/mass_storage.c:94: warning: return from incompatible pointer type
> 
> Declare the fsg_module_parameters fields as "bool" so that they can match the types
> passed in FSG_MODULE_PARAM_ARRAY macro.
> 
> Since commit 493c90ef (module_param: check that bool parameters really are bool.), 
> moduleparam.h was changed in a way that the "bool" parameter type now really
> requires "bool" type and no longer allows "unsigned int".
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> Acked-by: Michal Nazarewicz <mina86@xxxxxxxxxx>

applied, thanks

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux