Re: [PATCH 0/3] cdc-wdm: minor obvious fixes and improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Oliver Neukum <oliver@xxxxxxxxxx> writes:
> Am Montag, 16. Januar 2012, 12:41:46 schrieb Bjørn Mork:
>
>> All these patches have been briefly tested against an Ericsson F3507g
>> modem with two proper AT command speaking WDM interfaces.
>
> Have you tried with autosuspend activated?

Have to ask the stupid questions... How do I do that? Is this it?: 

nemi:/lib/modules/3.1.0-1-amd64/misc# grep . /sys/class/usb/cdc-wdm0/device/../power/*
/sys/class/usb/cdc-wdm0/device/../power/active_duration:1408128
/sys/class/usb/cdc-wdm0/device/../power/async:enabled
/sys/class/usb/cdc-wdm0/device/../power/autosuspend:1
/sys/class/usb/cdc-wdm0/device/../power/autosuspend_delay_ms:1000
/sys/class/usb/cdc-wdm0/device/../power/connected_duration:1425880
/sys/class/usb/cdc-wdm0/device/../power/control:auto
/sys/class/usb/cdc-wdm0/device/../power/level:auto
/sys/class/usb/cdc-wdm0/device/../power/persist:1
/sys/class/usb/cdc-wdm0/device/../power/runtime_active_kids:0
/sys/class/usb/cdc-wdm0/device/../power/runtime_active_time:1407328
/sys/class/usb/cdc-wdm0/device/../power/runtime_enabled:enabled
/sys/class/usb/cdc-wdm0/device/../power/runtime_status:suspended
/sys/class/usb/cdc-wdm0/device/../power/runtime_suspended_time:17672
/sys/class/usb/cdc-wdm0/device/../power/runtime_usage:0
/sys/class/usb/cdc-wdm0/device/../power/wakeup:disabled

nemi:/lib/modules/3.1.0-1-amd64/misc# grep . /sys/class/usb/cdc-wdm0/device/power/*
/sys/class/usb/cdc-wdm0/device/power/async:enabled
/sys/class/usb/cdc-wdm0/device/power/runtime_active_kids:0
/sys/class/usb/cdc-wdm0/device/power/runtime_enabled:enabled
/sys/class/usb/cdc-wdm0/device/power/runtime_status:suspended
/sys/class/usb/cdc-wdm0/device/power/runtime_usage:0

nemi:/lib/modules/3.1.0-1-amd64/misc# grep . /sys/class/usb/cdc-wdm0/power/*
/sys/class/usb/cdc-wdm0/power/async:disabled
grep: /sys/class/usb/cdc-wdm0/power/autosuspend_delay_ms: Input/output error
/sys/class/usb/cdc-wdm0/power/control:auto
/sys/class/usb/cdc-wdm0/power/runtime_active_kids:0
/sys/class/usb/cdc-wdm0/power/runtime_active_time:0
/sys/class/usb/cdc-wdm0/power/runtime_enabled:disabled
/sys/class/usb/cdc-wdm0/power/runtime_status:unsupported
/sys/class/usb/cdc-wdm0/power/runtime_suspended_time:0
/sys/class/usb/cdc-wdm0/power/runtime_usage:0

I do however note the "runtime_status:unsupported" on the cdc-wdm
device.  That's probably not good?

I think I need an autosuspend crash course.


>> The first patch should be a pretty obvious race, although I don't know
>> how to trigger it intentionally.
>> 
>> The second patch improves the useability of this driver from 0% to
>> near 100% for me by allowing simultaneous read/write.
>
> Good. Can you confirm this is a regression from 2.6.32?

Yes it is.  Not sure exactly when it was introdused.  I noticed it only
after switch from the 2.6.32 based Debian squeeze kernel to one of the
first 3.0.x based Debian kernels.



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux