Re: [PATCH 0/3] cdc-wdm: minor obvious fixes and improvements

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, 16. Januar 2012, 12:41:46 schrieb Bjørn Mork:
> Now you've done it, Oliver :-)  This is only the first series of what
> to expect.  And it will be getting worse as I dig myself closer and
> closer to something I can use instead of my own banal attemt on
> implementing the same functionality as this driver.

Good.
 
> All these patches have been briefly tested against an Ericsson F3507g
> modem with two proper AT command speaking WDM interfaces.

Have you tried with autosuspend activated?
 
> The first patch should be a pretty obvious race, although I don't know
> how to trigger it intentionally.
> 
> The second patch improves the useability of this driver from 0% to
> near 100% for me by allowing simultaneous read/write.

Good. Can you confirm this is a regression from 2.6.32?

> The third patch fixes a minor glitch I observe if I leave a process
> reading from the device when it's removed. With this patch, the
> read is unblocked on device removal, allowing the removal process
> to finish. This is a common case for me, as my laptop will disconnect
> the Ericsson modem using rfkill on suspend.

I am afraid the third patch is not acceptable in the current state.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux