Re: [PATCH] usb: musb: drop superfluous pm_runtime calls around musb_shutdown

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 12, 2012 at 5:55 PM, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote:
> On Thu, Jan 12, 2012 at 5:45 PM, Felipe Contreras
> <felipe.contreras@xxxxxxxxx> wrote:
>> On Thu, Jan 12, 2012 at 3:21 PM, Grazvydas Ignotas <notasas@xxxxxxxxx> wrote:
>>> Since commit 4f9edd2d7e8d "usb: musb: Fix the crash issue during reboot"
>>> musb_shutdown() does pm_runtime_get_sync/pm_runtime_put by itself, so
>>> this no longer needs to be done by the caller. Also, musb_exit_debugfs()
>>> doesn't access the device, so just drop those runtime_pm calls.
>>
>> I don't understand what is the relationship with 4f9edd2d7e8d and
>> musb_shutdown(), it seems this patch is basically reverting
>> 4f9edd2d7e8d.
>
> No it's not, read my patch and it's description again. 4f9edd2d7e8d is
> patching musb_shutdown(), mine musb_remove().

Ohh, OK.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux