Re: [PATCH] drivers: usb: gadget: f_mass_storage: Use "bool" instead of "int" in fsg_module_parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 Jan 2012 16:28:21 +0100, Fabio Estevam <festevam@xxxxxxxxx> wrote:
On file_storage.c I don't any see variable types mismatches.

The members of mod_data struct match the types passed to the several
module_param_named lines.

Not really.  ro and nofua are both int[] and corresponding
module_param_array_named()s use “bool”.  The same for non-array parameters.
That's also why I'm confused why you even got warnings for f_mass_storage
in the first place -- it seems to work everywhere else.

--
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +----<email/xmpp: mpn@xxxxxxxxxx>--------------ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux