Re: [PATCH] USB: ftdi_sio: fix TIOCSSERIAL baud_base handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 10, 2012 at 03:09:17PM -0800, Greg Kroah-Hartman wrote:
> On Tue, Jan 10, 2012 at 11:33:37PM +0100, Johan Hovold wrote:
> > Return EINVAL if new baud_base does not match the current one.
> > 
> > The baud_base is device specific and can not be changed. This restores
> > the old (pre-2005) behaviour which was changed due to a
> > misunderstanding regarding this fact (see
> > https://lkml.org/lkml/2005/1/20/84).
> 
> So this should get added to all of the stable kernels as well, right?

Yes, probably. I thought I'd let you decide, given that this behaviour
has been around since 2005 and that it's mostly a matter of being notified
that "no, the baud_base cannot be changed".

The code as it stands is incorrect and should be fixed, no doubt. So I
should probably have added the cc-stable tag myself.

Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux