Re: [PATCH] usb: cdc_ether: Ignore bogus union descriptor for RNDIS devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Dienstag, 10. Januar 2012, 23:15:16 schrieb Bjørn Mork:
> -                               goto bad_desc;
> +                               /* Fallback to guessing for rndis
> +                                * class devices with bogus union
> +                                * descriptor.
> +                                * Fixes some Samsung Android devices
> +                                */
> +                               if (rndis)
> +                                       info->u = NULL;
> +                               else
> +                                       goto bad_desc;

You are trying something subtle here. Stop doing that. Use a dedicated flag
or a clearly named goto.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux