On 01/10/2012 07:18 PM, Sarah Sharp wrote:
On Tue, Jan 10, 2012 at 10:03:37AM +0100, Sebastian Andrzej Siewior wrote:
* Sarah Sharp | 2012-01-09 15:07:40 [-0800]:
+ if (le16_to_cpu(udev->descriptor.bcdUSB)< 0x0300&&
+ udev->bos&& udev->bos->ss_cap)
ss_cap should only be provided by SS devices. Not sure how much sense it
makes to manufactor a device which does not have the USB_5GBPS_OPERATION
bit set.
I'm confused about what you're asking me to do here. Are you saying I
should drop the bcd.USB check and just look at the ss_cap?
No, what you do is good. I just mentioned that the ss_cap field has a
bit which says USB_5GBPS_OPERATION and should be always set. So you
*might* want to check it as well. Ignoring it wouldn't cause any false
positives I guess.
Sarah Sharp
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
