Re: [PATCH] USB: Warn about USB3 devices plugged into USB2 hub.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/10/2012 04:16 PM, Alan Stern wrote:
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 6bbe3c3..c80b088 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -3960,6 +3960,7 @@ int xhci_gen_setup(struct usb_hcd *hcd, xhci_get_quirks_t get_quirks)
  	u32			temp;

  	hcd->self.sg_tablesize = TRBS_PER_SEGMENT - 2;
+	usb3_controller_available();

  	if (usb_hcd_is_primary_hcd(hcd)) {
  		xhci = kzalloc(sizeof(struct xhci_hcd), GFP_KERNEL);

Not good.  This fails when an xHCI controller is removed.

but the user had a xhci controller during the life time of the system.

Then you would not print this message unless we have such a controller.
This could be extended to usb2 in 1.1 port but I guess this is no longer
required :)

You don't have to be so complicated about it.  Just copy the logic
used for highspeed_hubs in hub.c.

Actually, the more I look around it the better it looks.

Alan Stern

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux