On Tue, 2012-01-10 at 18:04 +0800, Andiry Xu wrote: > On 01/10/2012 04:59 PM, Alex,Shi wrote: > >>> .irq = xhci_irq, > >>> - .flags = HCD_MEMORY | HCD_USB3 | HCD_SHARED, > >>> + .flags = HCD_MEMORY | HCD_USB3 | HCD_SHARED | > >>> + HCD_MSI_FST, > >>> > >>> /* > >>> * basic lifecycle operations > >> > >> OK, I think this patch answers my question for patch2... so you changed > >> the behaviour for all xHCI pci hosts, not limited to Intel products. > >> > >> 1. With this patch, I think the free_irq() part in xhci_try_enable_msi() > >> can be removed. > >> 2. Why don't you merge patch2 and patch3? You defined a Intel device ID > >> in patch1, use it in patch2, and then remove the code in patch3... With > >> patch2 and 3 merged, you don't need to add any device ID at all. > > > > Yes, the patch3 can cover what's the patch2 doing. I split them because > > I got some suggestions: the patch3 is easy to revert if there are > > something bad was triggered. > > > > And do you need the new flag HCD_MSI_FST here? Can you simply use > HCD_USB3 for your purpose? I got some reminders that there should be other bus host USB3 hcd in future. But the MSI is PCIe only. BTW, I written the version 2 of this patch. Please review them. Thanks! > > Thanks, > Andiry > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
