Re: [PATCH 3/5 v2] usb/dummy_hcd: add sg support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 9 Jan 2012, Sebastian Andrzej Siewior wrote:

> This patch adds sg support to dummy_hcd. It seems that uas is not able
> to work with a hcd which does not support sg only based transfers.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> * Alan Stern | 2012-01-09 12:40:17 [-0500]:
> 
> >WARN_ON would be okay, and fail the transfer.  Or just remove the tests 
> >entirely; that wouldn't be any worse than having them fire.  As you 
> >say, they should never happen.
> 
> Here is a version with WARN_ON() instead of BUG_ON(). One could be
> developing a driver and get it wrong. So having atleast a WARN_ON() is a
> good hint. And dummy is lacking sg support for device side :)

Okay, this is fine.

Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux