On Mon, Jan 02, 2012 at 05:44:42PM -0800, Sarah Sharp wrote:
> Hi Andiry,
>
> On Thu, Dec 22, 2011 at 02:23:06PM +0800, Andiry Xu wrote:
> > Rename the fields in USB SS device capability descriptor to comply
> > with USB3.0 specification.
>
> This is more than a simple rename, right? Most of it is a rename, but
> there's also a bug fix in the composite driver to make sure it converts
> the default U2 latency to le16. Maybe that should be a separate bug fix
> marked for stable before the rename patch?
definitely. Keep bugfixes separate. Ideally the bugfix before the rename
so it's easier to apply to stable kernels.
> > diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c
> > index c7f291a..735beb4 100644
> > --- a/drivers/usb/gadget/storage_common.c
> > +++ b/drivers/usb/gadget/storage_common.c
> > @@ -597,8 +597,8 @@ static __maybe_unused struct usb_ss_cap_descriptor fsg_ss_cap_desc = {
> > | USB_HIGH_SPEED_OPERATION
> > | USB_5GBPS_OPERATION),
> > .bFunctionalitySupport = USB_LOW_SPEED_OPERATION,
> > - .bU1devExitLat = USB_DEFAULT_U1_DEV_EXIT_LAT,
> > - .bU2DevExitLat = USB_DEFAULT_U2_DEV_EXIT_LAT,
> > + .bU1DevExitLat = USB_DEFAULT_U1_DEV_EXIT_LAT,
> > + .wU2DevExitLat = USB_DEFAULT_U2_DEV_EXIT_LAT,
cpu_to_le16() ??
--
balbi
Attachment:
signature.asc
Description: Digital signature
