Re: [PATCH 4/15] vub300: fix module parameter.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2011-12-15 at 13:34 +1030, Rusty Russell wrote:
> You didn't mean this to be a bool.
> 
> Cc: Tony Olech <tony.olech@xxxxxxxxxxxxxxxxxxxxxx>
> Cc: Chris Ball <cjb@xxxxxxxxxx>
> Cc: linux-mmc@xxxxxxxxxxxxxxx
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> ---
>  drivers/mmc/host/vub300.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -259,7 +259,7 @@ static int firmware_rom_wait_states = 0x
>  static int firmware_rom_wait_states = 0x1C;
>  #endif
>  
> -module_param(firmware_rom_wait_states, bool, 0644);
> +module_param(firmware_rom_wait_states, int, 0644);
>  MODULE_PARM_DESC(firmware_rom_wait_states,
>  		 "ROM wait states byte=RRRIIEEE (Reserved Internal External)");
>  
> --
You are right.
I don't know how that slipped through
Acked-by: Tony Olech <tony.olech@xxxxxxxxxxxxxxxxxxxxxx>
Acked-by: Tony Olech <tony@xxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux