re: usb: renesas_usbhs: add usbhs_pipe_attach() method

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Kuninori Morimoto,

This is a semi-automatic email about new static checker warnings.

The patch e5679d07a6ca: "usb: renesas_usbhs: add usbhs_pipe_attach() 
method" from Dec 8, 2011, leads to the following Smatch complaint:

drivers/usb/renesas_usbhs/mod_host.c +642 usbhsh_queue_done()
	 warn: variable dereferenced before check 'urb' (see line 636)

drivers/usb/renesas_usbhs/mod_host.c
   635		struct urb *urb = ureq->urb;
   636		struct usbhsh_ep *uep = usbhsh_ep_to_uep(urb->ep);
                                                         ^^^^^^^
New dereference.

   637		struct device *dev = usbhs_priv_to_dev(priv);
   638		int status = 0;
   639	
   640		dev_dbg(dev, "%s\n", __func__);
   641	
   642		if (!urb) {
                    ^^^^
Old check.

   643			dev_warn(dev, "pkt doesn't have urb\n");
   644			return;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux