Re: [PATCH 1/5] usb: gadget: introduce support for sg lists

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 14, 2011 at 03:59:59PM -0500, Alan Stern wrote:
> On Wed, 14 Dec 2011, Felipe Balbi wrote:
> 
> > Some controllers support scatter/gather transfers
> > and that might be very useful for some gadget drivers.
> > 
> > Signed-off-by: Felipe Balbi <balbi@xxxxxx>
> 
> > @@ -88,6 +91,9 @@ struct usb_request {
> >  	unsigned		length;
> >  	dma_addr_t		dma;
> >  
> > +	struct scatterlist	*sg;
> > +	unsigned		num_sgs;
> > +
> 
> You may also need a num_mapped_sgs field.  See commit
> bc677d5b64644c399cd3db6a905453e611f402ab (usb: fix number of mapped SG
> DMA entries) in Greg's usb-next branch.

Makes sense, I didn't envision the possibility of dma_map_sg() not
mapping all entries. Will change that part re-test and re-send.

FYI, my test ran over night and I transferred over 800 GiBs, it's still
running while I reply to mails ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux