Re: [PATCH] target: uasp: gadget: pass SGs for gadget driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 15, 2011 at 10:27:34AM +0100, Sebastian Andrzej Siewior wrote:
> * Felipe Balbi | 2011-12-14 22:18:17 [+0200]:
> 
> >This is the patch i applied on top of Sebastian's UASP
> >Gadget.
> 
> Thanks. I throw this into my tree.
> 
> >--- a/drivers/target/uasp/gadget.c
> >+++ b/drivers/target/uasp/gadget.c
> >@@ -407,10 +413,12 @@ static void guas_data_write_cmpl(struct usb_ep *ep, struct usb_request *req)
> > 		goto cleanup;
> > 	}
> > 
> >-	sg_copy_from_buffer(se_cmd->t_data_sg,
> >-			se_cmd->t_data_nents,
> >-			cmd->data_buf,
> >-			se_cmd->data_length);
> >+	if (req->num_sgs == 0) {
> 
> I think, I change it to
> 
> |	if (gadget->sg_tablesize == 0) {
> 
> Don't you think?

I think not, later we might want to have simpler ways to force non-SG
usage for the purpose of testing and this will prevent us having to
change this part ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux