Re: [PATCHv8 12/19] usb: otg: twl6030: Start using struct usb_otg

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Dec 9, 2011 at 3:59 PM, Heikki Krogerus
<heikki.krogerus@xxxxxxxxxxxxxxx> wrote:
> Use struct usb_otg members with OTG specific functions instead
> of usb_phy members.
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Tested-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> Cc: Hema HK <hemahk@xxxxxx>
> ---
>  drivers/usb/otg/twl6030-usb.c |   93 +++++++++++++++++++++--------------------
>  1 files changed, 47 insertions(+), 46 deletions(-)
>
> diff --git a/drivers/usb/otg/twl6030-usb.c b/drivers/usb/otg/twl6030-usb.c
> index 2f5c299..3441738 100644
> --- a/drivers/usb/otg/twl6030-usb.c
> +++ b/drivers/usb/otg/twl6030-usb.c
> @@ -87,7 +87,8 @@
>  #define        VBUS_DET                        BIT(2)
>
>  struct twl6030_usb {
> -       struct usb_phy  otg;
> +       struct usb_phy          phy;
> +       struct usb_otg          otg;
I see otg being added to  twl6030_usb (changes from v7). Whats the
reason behind this?
I think its better to have it in the way you had in v7.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux