Re: [PATCH 2/2] usb/dummy_hcd: initialize max_streams early

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Alan Stern | 2011-12-08 15:15:26 [-0500]:

>> >No, I meant the three lines above, where max_streams is set to 0 if the 
>> >emulated connection isn't SuperSpeed.  Leave it in and let it run.
>> 
>> You think it makes sense to do so? It is only used by the two
>> ep_autoconfig functions which look for the proper ep which is done at
>> bind time. So afterwards it is never looked at.
>
>Binding can occur many times during the life of dummy-hcd.  Besides, 
>it's not exactly a lot of code.  I prefer to leave it in.

At bind-time you have to have that max_streams flag set. This happens
currently only once in the life time of gadget.
Meaning:
- dummy's init, max_streams != 0
- load gadget, connect at HS, max_streams drops to 0
- replace the gadget while dummy is unconnected
- the new gadget gets only eps with max_streams = 0. bind is done only
  once.

Since a gadget grabs endpoints only once it is wise to grab those with
max_stream capability _if_ the gadget supports SS. However if you happen
to connect at HS speed you may not use your stream feature even if the
endpoint supports it.

>Alan Stern

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux