* Alan Stern | 2011-11-07 10:08:47 [-0500]:
>On Mon, 7 Nov 2011, Sebastian Andrzej Siewior wrote:
>
>> >> {
>> >> - u32 i;
>> >> -
>> >> - if (dum->gadget.speed == USB_SPEED_SUPER) {
>> >> - for (i = 0; i < DUMMY_ENDPOINTS; i++)
>> >> - dum->ep[i].ep.max_streams = 0x10;
>> >> + if (dum->gadget.speed == USB_SPEED_SUPER)
>> >> dum->ep[0].ep.maxpacket = 9;
>> >> - } else {
>> >> - for (i = 0; i < DUMMY_ENDPOINTS; i++)
>> >> - dum->ep[i].ep.max_streams = 0;
>> >
>> >It might be a good idea to keep this code -- just to be safe.
>> Are you talking about an #if 0 block?
>
>No, I meant the three lines above, where max_streams is set to 0 if the
>emulated connection isn't SuperSpeed. Leave it in and let it run.
You think it makes sense to do so? It is only used by the two
ep_autoconfig functions which look for the proper ep which is done at
bind time. So afterwards it is never looked at.
>(Another thing I just noticed: i should be declared as an "int", not a
>"u32".)
>
>> Sure. However I'm not sure if we could change it to streams_supported. I
>> saw only one real hardware so far so my view is very limited. It
>> supported streams on all endpoints and the number of limited streams
>> seems not to be limited.
>
>I don't know about USB-3 hardware in general. But 16 streams seems
>like a reasonable number to use for testing. You could make it a sysfs
>attribute if you want, although that might be overkill.
16 is probably enough. According to Sarah's code I see
| /* Max size for Primary Stream Arrays - 2^(n+1), where n is bits 12:15 */
and that is 2^(3+1) = 16.
>Alan Stern
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
