On Tue, Dec 06, 2011 at 09:09:55AM -0800, Greg KH wrote: > On Tue, Dec 06, 2011 at 08:39:58AM -0800, Shimrit Malichi wrote: > > > > > On Sun, Dec 04, 2011 at 10:18:14PM +0200, Shimrit Malichi wrote: > > >> This patch series implements the UAS gadget driver. > > >> > > >> It has been tested using the following: > > >> 1. Linux UAS host driver > > >> 2. Internaly developed unittests framework > > >> > > >> The device is functional. More stress tests are needed. > > >> > > >> TODO: Further testing > > >> De-register the gadget if the main thread dies. > > > > > > What about all of the review comments you seem to be ignoring that have > > > been made for this driver in the past? > > > > > > greg k-h > > > > > We addressed most of the comments. One of them was indeed to use the > > target framework, however when we asked an additional information about > > how to use this framework we didn't get a detailed reply. Sebastian gave > > an answer on how to use it yesterday. We will study his answer, and come > > up with a new code. > > No one is going to normally give you such a detailed answer as he did. > You were told to go use that interface, and Sebastian did just that, why > couldn't you have done that in the first place, saving you, and everyone > else here, time and effort of telling you to go do that again? other than that, it's just waste of time if you go write new code, now that Sebastian already has that almost ready. Save yourself sometime and just help Sebastian finishing what he's already done. Even testing is welcome at this stage. -- balbi
Attachment:
signature.asc
Description: Digital signature
