On Wed, Nov 23, 2011 at 11:19:44PM -0800, Neil Zhang wrote: > > -----Original Message----- > > From: Peter Chen [mailto:hzpeterchen@xxxxxxxxx] > > Sent: 2011年11月24日 14:06 > > To: Greg KH > > Cc: Neil Zhang; balbi@xxxxxx; Haojian Zhuang; linux-usb@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH v1] USB: OTG should be linked before Host > > > > On Thu, Nov 24, 2011 at 12:17 AM, Greg KH <gregkh@xxxxxxx> wrote: > > > On Wed, Nov 23, 2011 at 06:38:48PM +0800, Neil Zhang wrote: > > >> For OTG controller, the host driver will call function > > >> otg_get_transceiver to get the otg transceiver, so we need to init > > the > > >> OTG driver before HOST. > > > > > I agree with it, at freescale i.mx platform, we also need to init otg > > first, then the host > > if otg function is enabled. > > > > > How do you handle this if these drivers are built as modules? > > We require the user load module by order, and write it at UserGuide. > > > > I find at older kernel version, like 2.6.38, the otg was built firstly > > at usb module. > > Actually, it was changed by the following patch. > > commit 4661ffc91befc8c5ee080720120da1d53851060a > Author: Felipe Balbi <balbi@xxxxxx> > Date: Thu Apr 7 10:59:34 2011 +0300 > > usb: don't enter usb subdirectories directly > > Instead, make we enter usb/ directory on all > needed cases and enter the subdirectories from > drivers/usb/Makefile. > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> > > Hi Balbi, > Do you have any concern to change it? not from my side, we need the transceivers before the DRD controllers can probe. FWIW: Acked-by: Felipe Balbi <balbi@xxxxxx> -- balbi
Attachment:
signature.asc
Description: Digital signature