On Thu, Nov 24, 2011 at 12:17 AM, Greg KH <gregkh@xxxxxxx> wrote: > On Wed, Nov 23, 2011 at 06:38:48PM +0800, Neil Zhang wrote: >> For OTG controller, the host driver will call function >> otg_get_transceiver to get the otg transceiver, so we need to init the >> OTG driver before HOST. > I agree with it, at freescale i.mx platform, we also need to init otg first, then the host if otg function is enabled. > How do you handle this if these drivers are built as modules? We require the user load module by order, and write it at UserGuide. I find at older kernel version, like 2.6.38, the otg was built firstly at usb module. > >> Signed-off-by: Neil Zhang <zhangwm@xxxxxxxxxxx> >> --- >> drivers/usb/Makefile | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/usb/Makefile b/drivers/usb/Makefile >> index 75eca76..53a7bc0 100644 >> --- a/drivers/usb/Makefile >> +++ b/drivers/usb/Makefile >> @@ -6,6 +6,8 @@ >> >> obj-$(CONFIG_USB) += core/ >> >> +obj-$(CONFIG_USB_OTG_UTILS) += otg/ >> + >> obj-$(CONFIG_USB_DWC3) += dwc3/ >> >> obj-$(CONFIG_USB_MON) += mon/ >> @@ -51,7 +53,6 @@ obj-$(CONFIG_USB_SPEEDTOUCH) += atm/ >> >> obj-$(CONFIG_USB_MUSB_HDRC) += musb/ >> obj-$(CONFIG_USB_RENESAS_USBHS) += renesas_usbhs/ >> -obj-$(CONFIG_USB_OTG_UTILS) += otg/ >> obj-$(CONFIG_USB_GADGET) += gadget/ >> >> obj-$(CONFIG_USB_COMMON) += usb-common.o > > This is a big change that I would like to get some acks by other people > before making, are you sure you didn't just break any other hardware > that needs the host driver initialized first? > > greg k-h > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- BR, Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html