On Mon, Nov 14, 2011 at 01:52:16AM +0000, Jingoo Han wrote: > > -----Original Message----- > > From: Greg KH [mailto:gregkh@xxxxxxx] > > Sent: Saturday, November 12, 2011 1:34 PM > > To: Jingoo Han > > Cc: Alan Stern; linux-usb@xxxxxxxxxxxxxxx; Joonyoung Shim > > Subject: Re: [PATCH] USB: ehci-s5p: add mssing platform_set_drvdata > > > > On Thu, Nov 10, 2011 at 06:55:42PM +0900, Jingoo Han wrote: > > > This patch adds mssing platform_set_drvdata to the remove function. > > > > > > Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > > --- > > > drivers/usb/host/ehci-s5p.c | 1 + > > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > > > diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c > > > index 024b65c..152504b 100644 > > > --- a/drivers/usb/host/ehci-s5p.c > > > +++ b/drivers/usb/host/ehci-s5p.c > > > @@ -177,6 +177,7 @@ static int __devexit s5p_ehci_remove(struct > > platform_device *pdev) > > > > > > usb_put_hcd(hcd); > > > kfree(s5p_ehci); > > > + platform_set_drvdata(pdev, NULL); > > > > Why is this needed? > I thought that it's needed, because other usb host drivers use this at remove function > such as ehci-au1xxx.c, ohci-jz4740.c, ehci-octeon.c, ehci-mxc.c, ohci-pnx4008.c > and ehci-vt8500.c. > If you think that it is unnecessary, please don't submit this patch. I think it's unneeded, if you actually have a test that this is required, then I would be very interested in finding that out. So I'll drop these patches, thanks. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
