Re: [PATCH 1/4] usb: renesas_usbhs: bugfix: care pipe direction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 24, 2011 at 02:24:49AM -0700, Kuninori Morimoto wrote:
> renesas_usbhs is caring pipe type and its direction.
> but current usbhs_endpoint_alloc() didn't check direction.
> this patch modify it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

this patch adds a compile warning:

drivers/usb/renesas_usbhs/mod_host.c: In function
‘usbhsh_endpoint_alloc’: drivers/usb/renesas_usbhs/mod_host.c:443:2:
warning: ‘pipe’ may be used uninitialized in this function
[-Wuninitialized]

check is below is acceptable:

diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
index 6ae6070..f8f612c 100644
--- a/drivers/usb/renesas_usbhs/mod_host.c
+++ b/drivers/usb/renesas_usbhs/mod_host.c
@@ -442,7 +442,7 @@ usbhsh_endpoint_alloc_find_pipe:
 
 	dev_dbg(dev, "%s [%d-%s](%p)\n", __func__,
 		usbhsh_device_number(hpriv, udev),
-		usbhs_pipe_name(pipe), uep);
+		usbhs_pipe_name(uep->pipe), uep);
 
 	return uep;
 }

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux