Re: [PATCH] USB: gadget: fix MIDI gadget jack allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/08/2011 12:53 PM, Felipe Balbi wrote:
On Tue, Nov 08, 2011 at 12:40:00PM +0100, Daniel Mack wrote:
 From fbaf8411b540c0146edcc7f611d7c4603df70918 Mon Sep 17 00:00:00 2001
From: Daniel Mack<zonque@xxxxxxxxx>
Date: Sat, 15 Oct 2011 13:45:05 +0200
Subject: [PATCH] USB: gadget: fix MIDI gadget jack allocation

The dynamic jack allocation of the MIDI gadget currently links all
external jacks to one single instance of an embedded jack. According to
the spec, this is only valid if these streams always carry the same data
stream, as described in the USB MIDI 1.0 spec, chapter 3.3.1.

Also, genius Windows 7(tm) terminates it's life cycle instantly with a
blue screen of death once a device with more than one input and output
port with the current implementation is connected.

While at it, and because it grew again by this change, allocate the
temporary function pointer list on the heap, not on the stack.

Signed-off-by: Daniel Mack<zonque@xxxxxxxxx>

I have applied this one to my fixes branch. I guess it's better to have
the gadget driver working then porting this to -stable later.


Ok, thanks a lot.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux