[PATCH 00/18] USB: serial: clean up and multi-read urb support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi, 

These patches clean up the usb serial subsystem by removing unnecessary code
and duplicated structures, and finally rewrites the generic read
implementation to use multiple read urbs (which can give a rough 50%
throughput increase).

A few comments to the patches:

  USB: serial: remove changelogs and old todo entries

    I decided to remove the remaining old changelog entries from the
    tree, but this one could be skipped if it's considered worth keeping them
    around (could always be retrieved through git otherwise).

  USB: omninet: fix write_room

    This one is a bug fix and makes you wonder whether anyone uses this driver
    as the bug was introduced in 2005...

  USB: omninet: clean up write-urb busy handling
  USB: cyberjack: clean up write-urb busy handling
  USB: keyspan_pda: clean up write-urb busy handling
  USB: serial: remove write_urb_busy field from usb_serial_port

    These patches removes the dedicated write_urb_busy flag from
    usb_serial_port by using the free write urb mask instead.

  USB: mos7720: remove incorrect read-urb check
  USB: mos7720: remove unused code
  USB: serial: remove unnecessary reinitialisations of urb->dev
  USB: serial: remove unnecessary reinitialisations of urb fields
  USB: serial: remove unnecessary bulk-urb re-fills
  USB: usb_debug: fix indentation

    Various clean ups which basically remove code based on no longer valid
    assumptions which could cause some confusion.

  USB: usb_debug: use process_read_urb
  USB: pl2303: return errors from usb_submit_urb in open
  USB: pl2302: clean up error handling in open
  USB: pl2303: use usb_serial_generic_open
  USB: serial: add support for multiple read urbs

    The first four patches replace all driver calls to
    usb_serial_generic_submit_read_urb which is then in turn replaced by a new
    function usb_serial_generic_submit_read_urbs in the final patch which adds
    multi-read urb support.

Thanks,
Johan


 Johan Hovold (18):
  USB: serial: remove changelogs and old todo entries
  USB: omninet: fix write_room
  USB: omninet: clean up write-urb busy handling
  USB: cyberjack: clean up write-urb busy handling
  USB: keyspan_pda: clean up write-urb busy handling
  USB: serial: remove write_urb_busy field from usb_serial_port
  USB: mos7720: remove incorrect read-urb check
  USB: mos7720: remove unused code
  USB: serial: remove unnecessary reinitialisations of urb->dev
  USB: serial: remove unnecessary reinitialisations of urb fields
  USB: serial: remove unnecessary bulk-urb re-fills
  USB: serial: reuse generic write urb and bulk-out buffer
  USB: usb_debug: fix indentation
  USB: usb_debug: use process_read_urb
  USB: pl2303: return errors from usb_submit_urb in open
  USB: pl2302: clean up error handling in open
  USB: pl2303: use usb_serial_generic_open
  USB: serial: add support for multiple read urbs

 drivers/usb/serial/ChangeLog.history  |  730 ---------------------------------
 drivers/usb/serial/belkin_sa.c        |   43 --
 drivers/usb/serial/ch341.c            |    1 -
 drivers/usb/serial/cyberjack.c        |   33 +--
 drivers/usb/serial/cypress_m8.c       |   29 --
 drivers/usb/serial/digi_acceleport.c  |  227 +----------
 drivers/usb/serial/garmin_gps.c       |    9 -
 drivers/usb/serial/generic.c          |   83 +++-
 drivers/usb/serial/io_edgeport.c      |    3 -
 drivers/usb/serial/io_ti.c            |   28 +--
 drivers/usb/serial/ipaq.c             |   34 --
 drivers/usb/serial/ir-usb.c           |   32 --
 drivers/usb/serial/keyspan.c          |   90 ----
 drivers/usb/serial/keyspan_pda.c      |   66 +---
 drivers/usb/serial/kobil_sct.c        |   25 --
 drivers/usb/serial/mct_u232.c         |   46 --
 drivers/usb/serial/mos7720.c          |   18 -
 drivers/usb/serial/mos7840.c          |    4 -
 drivers/usb/serial/omninet.c          |   51 +---
 drivers/usb/serial/opticon.c          |    1 -
 drivers/usb/serial/oti6858.c          |    9 -
 drivers/usb/serial/pl2303.c           |   17 +-
 drivers/usb/serial/sierra.c           |    1 -
 drivers/usb/serial/symbolserial.c     |    1 -
 drivers/usb/serial/ti_usb_3410_5052.c |   13 +-
 drivers/usb/serial/usb-serial.c       |   73 ++--
 drivers/usb/serial/usb_debug.c        |   13 +-
 drivers/usb/serial/whiteheat.c        |   58 ---
 include/linux/usb/serial.h            |   11 +-
 29 files changed, 142 insertions(+), 1607 deletions(-)
 delete mode 100644 drivers/usb/serial/ChangeLog.history

-- 
1.7.7

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux