On Sun, Nov 06, 2011 at 08:36:40PM +0800, Vishnu Nambiar wrote: > Its almost a week, I'm wondering if i am emailed the wrong group? Nope, this is the correct one. > Any advice? Sorry, its the first time I'm submitting a USB patch. Please realize that we are busy with the merge window, and don't have time to review stuff until next week at the earliest. Don't worry, your patch is not lost, and we will get back to it. But, as long as you asked, I'll give you these review comments based purely on your changelog comment: > On Mon, Oct 31, 2011 at 10:21 PM, Vishnu Nambiar > <vishnu@xxxxxxxxxxxxxxxxxx> wrote: > > > > Here are the list of changes: > > 1) Added devtree support into the code by adding > > ".of_match_table = isp116x_match" (see end of code). > > 2) Added a reference to the ndelay() function called isp116x_ndelay(). Therefore, if > > platform delay function is not defined in devicetree, the delay function will default > > to ndelay() by calling this reference function. > > 3) Use devm_kzalloc() during probe function. > > 4) pdata config setting now gets its bool values from the device tree. > > 5) Changed delay check to default to ndelay() if no plateform delay is used. You should only do one thing per patch, so care to break this up into at least 5 different patches? That's the correct way to do this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
