Good point. That said, I'm also not certain that you want to change UFI. Unlike the other transports, UFI was written (as far as I know) for USB devices. And I believe it says commands shall be 12 bytes only. So, allowing larger commands might be counter-productive. Matt On Mon, Oct 24, 2011 at 10:24 AM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, 24 Oct 2011, Matthew Dharm wrote: > >> Alan -- >> >> You realize that's an okay patch for testing, but not as a final >> solution, right? 8020 can't accept the short commands; they need to >> be at least 12 bytes.... > > Ah -- you didn't notice that the padding loop uses srb->cmd_len as its > index. When the loop finishes, srb->cmd_len will always be equal to 12 > unless it started out larger. > > Alan Stern > > -- Matthew Dharm Maintainer, USB Mass Storage driver for Linux -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
