Hi Felipe Thank you for checking patch > [1 <text/plain; us-ascii (quoted-printable)>] > On Sun, Oct 23, 2011 at 07:56:41PM -0700, Kuninori Morimoto wrote: > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > --- > > drivers/usb/renesas_usbhs/common.c | 2 +- > > drivers/usb/renesas_usbhs/common.h | 1 - > > 2 files changed, 1 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c > > index b0d09cb..71a8c91 100644 > > --- a/drivers/usb/renesas_usbhs/common.c > > +++ b/drivers/usb/renesas_usbhs/common.c > > @@ -95,7 +95,7 @@ struct usbhs_priv *usbhs_pdev_to_priv(struct platform_device *pdev) > > /* > > * syscfg functions > > */ > > -void usbhs_sys_clock_ctrl(struct usbhs_priv *priv, int enable) > > +static void usbhs_sys_clock_ctrl(struct usbhs_priv *priv, int enable) > > not related to $SUBJECT, but I wonder if this should be done by clock > API ? Thank you for your idea. SuperH chip has CPG (Clock Pulse Generator), and we use clock API to control it. Of course renesas_usbhs driver is using it. OTOH, renesas_usbhs USBHS has special bit to enable or halt the supply of CPG clock to this IP. So, SuperH clock API controls CPG only, USBHS specific register control is renesas_usbhs driver's task I think. Best regards --- Kuninori Morimoto -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
