[PATCH 1/2] g_printer: fix usb-spec conformity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Christian Kellermann <ck@xxxxxxxxx>

bMaxPacketSize specifies the maximum packet size for this endpoint in
bytes. According to usb spec valid values are 8, 16, 32, 64.

Without the patch the g_printer driver will fail the USB consortium's
Chapter 9 conformity test suite. A value from the set above needs to
be set.

For the printer device choosing the maximum value has been choosen to
reduce overhead for data transfers.

Signed-off-by: Christian Kellermann <ck@xxxxxxxxx>
Signed-off-by: Fabian Godehardt <fg@xxxxxxxxx>
---
 drivers/usb/gadget/printer.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/gadget/printer.c b/drivers/usb/gadget/printer.c
index a341dde..9f6be75 100644
--- a/drivers/usb/gadget/printer.c
+++ b/drivers/usb/gadget/printer.c
@@ -234,6 +234,7 @@ static struct usb_device_descriptor device_desc = {
 	.iManufacturer =	STRING_MANUFACTURER,
 	.iProduct =		STRING_PRODUCT,
 	.iSerialNumber =	STRING_SERIALNUM,
+	.bMaxPacketSize0 =	0x40,
 	.bNumConfigurations =	1
 };
 
-- 
1.7.5

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux