Re: [PATCH 1/2] g_printer: fix usb-spec conformity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 14, 2011 at 05:53:07AM +0200, Fabian Godehardt wrote:
> From: Christian Kellermann <ck@xxxxxxxxx>

No signed-off-by line, sorry, we can't accept this.

Also, why are you doing this?  What is wrong with our existing
structure?

> 
> ---
>  drivers/usb/gadget/printer.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/gadget/printer.c b/drivers/usb/gadget/printer.c
> index a341dde..6c37fc5 100644
> --- a/drivers/usb/gadget/printer.c
> +++ b/drivers/usb/gadget/printer.c
> @@ -234,7 +234,8 @@ static struct usb_device_descriptor device_desc = {
>  	.iManufacturer =	STRING_MANUFACTURER,
>  	.iProduct =		STRING_PRODUCT,
>  	.iSerialNumber =	STRING_SERIALNUM,
> -	.bNumConfigurations =	1
> +	.bNumConfigurations =	1,
> +	.bMaxPacketSize0 = 0x40,

Please keep the same formatting, it looks crufty now, why would you want
to add crufty code?  Please make it pretty, it really matters.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux