Hi,
On Mon, Oct 10, 2011 at 11:10:22AM -0400, Alan Stern wrote:
> On Mon, 10 Oct 2011, Felipe Balbi wrote:
>
> > this patch adds superspeed descriptors for the
> > storage gadgets.
>
> This looks quite good. There's one thing I'm not sure about:
>
> > --- a/drivers/usb/gadget/file_storage.c
> > +++ b/drivers/usb/gadget/file_storage.c
> > @@ -586,7 +586,22 @@ dev_qualifier = {
> > .bNumConfigurations = 1,
> > };
> >
> > +static int populate_bos(struct fsg_dev *fsg, u8 *buf)
> > +{
> > + fsg_bos_desc.wTotalLength = USB_DT_BOS_SIZE
> > + + USB_DT_USB_SS_CAP_SIZE + USB_DT_USB_EXT_CAP_SIZE;
>
> Is there any particular reason this field is computed dynamically?
> Does it need to be different for the various drivers?
not really, no. I can move it back to static initialization.
--
balbi
Attachment:
signature.asc
Description: Digital signature
