Re: [RFC/PATCH 2/2] usb: gadget: storage: add superspeed support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 10 Oct 2011, Felipe Balbi wrote:

> this patch adds superspeed descriptors for the
> storage gadgets.

This looks quite good.  There's one thing I'm not sure about:

> --- a/drivers/usb/gadget/file_storage.c
> +++ b/drivers/usb/gadget/file_storage.c
> @@ -586,7 +586,22 @@ dev_qualifier = {
>  	.bNumConfigurations =	1,
>  };
>  
> +static int populate_bos(struct fsg_dev *fsg, u8 *buf)
> +{
> +	fsg_bos_desc.wTotalLength = USB_DT_BOS_SIZE
> +		+ USB_DT_USB_SS_CAP_SIZE + USB_DT_USB_EXT_CAP_SIZE;

Is there any particular reason this field is computed dynamically?  
Does it need to be different for the various drivers?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux