Re: Unifying the hc_driver structures for EHCI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Oct 03, 2011 at 02:50:33PM -0400, Alan Stern wrote:
> Most of the EHCI drivers don't differ very much in their hc_driver 
> structures.  The product_desc field varies, but that doesn't matter 
> because its only use is to be copied into the hcd->product_desc field, 
> which can be overwritten later.
> 
> The description field can be eliminated and replaced by the name of the
> parent controller device's driver.  In many cases that's the same as
> what it already is.

true, that's not a big problem.

> The reset field will be a problem.  I'm going to put it off for now.
> 
> Oddly enough, hcd_priv_size differs in a few cases; some of the drivers
> add private data of their own.  ehci-spear adds a clock, ehci-fsl adds
> a PHY setting, and ehci-pxa168 adds both a clock and some PHY
> resources.  We're going to have to figure out a way to accomodate all
> of them if they are to share the same hc_driver structure.  Any ideas?

just don't allocate priv_size yourself ? Something like
dev->driver_data ?

-- 
balbi

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux