Hi, 2011/09/30 17:13, Felipe Balbi wrote: > Hi, > > On Mon, Sep 26, 2011 at 05:42:39PM +0900, Yoshihiro Shimoda wrote: < snip > >> --- a/drivers/usb/gadget/r8a66597-udc.c >> +++ b/drivers/usb/gadget/r8a66597-udc.c >> @@ -733,7 +733,7 @@ static void irq_ep0_write(struct r8a66597_ep *ep, struct r8a66597_request *req) >> /* write fifo */ >> if (req->req.buf) { >> if (size > 0) >> - r8a66597_write_fifo(r8a66597, ep->fifoaddr, buf, size); >> + r8a66597_write_fifo(r8a66597, ep, buf, size); > > the patch looks fine, but changing the prototype of this function > doesn't seem to be part of this patch. So I think you should first fix > that function's prototype, than apply the rest of the fix to WR0 and WR1 > as another patch. > Thank you very much for your review. I will create the separate patches and submit it. Best regards, Yoshihiro Shimoda -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html