Hi,
On Tue, Sep 27, 2011 at 10:51:48PM -0700, Paul Zimmerman wrote:
> SETSTALL for control EP pair must always be sent to OUT EP
>
> Signed-off-by: Paul Zimmerman <paulz@xxxxxxxxxxxx>
this is largely unnecessary :-) See what we do on stall and restart:
214 static void dwc3_ep0_stall_and_restart(struct dwc3 *dwc)
215 {
216 struct dwc3_ep *dep = dwc->eps[0];
217
218 /* stall is always issued on EP0 */
219 __dwc3_gadget_ep_set_halt(dwc->eps[0], 1);
220 dwc->eps[0]->flags = DWC3_EP_ENABLED;
221
222 if (!list_empty(&dep->request_list)) {
223 struct dwc3_request *req;
224
225 req = next_request(&dep->request_list);
226 dwc3_gadget_giveback(dep, req, -ECONNRESET);
227 }
228
229 dwc->ep0state = EP0_SETUP_PHASE;
230 dwc3_ep0_out_start(dwc);
231 }
so stall will always be set on ep0out.
On the other hand, there's is some extra unnecessary code on that
function which could simply be removed.
--
balbi
Attachment:
signature.asc
Description: Digital signature
