Hi, On Sun, Sep 18, 2011 at 01:44:10AM -0700, Greg KH wrote: > On Mon, Sep 12, 2011 at 06:18:32PM +0300, Felipe Balbi wrote: > > Hi Greg, > > > > ( $ echo maintainer > /sys/felipe/mode ) > > > > as you asked, I have rebuilt the pull request and checked that it merges > > on top of the commit I have. If it doesn't work, then it's because I > > don't have your most recent objects and we will have to wait until Hera > > is back up and running. > > > > Anyway, below is the pull request. A short summary here: > > > > . MUSB now has mode1 DMA enabled for gadgets which set short_not_ok > > flag > > > > . Storage gadget doesn't assume anymore block size is aligned to > > wMaxPacketSize > > > > . Number of buffers on storage gadget is now selectable from Kconfig > > > > . DWC3 driver now works fine against linux host and MCOP (a pre-silicon > > validation platform from TI) > > > > ( $ echo vacations > /sys/felipe/mode ) > > > > The following changes since commit 55a46269ccedec140e2487a2344e8a247d48b385: > > > > USB: pl2303: remove unreachable code (2011-08-26 11:27:50 -0700) > > > > are available in the git repository at: > > git://gitorious.org/usb/usb.git for-next > > This breaks the build: > > In file included from drivers/usb/gadget/file_storage.c:283:0: > drivers/usb/gadget/storage_common.c: In function ‘fsg_num_buffers_validate’: > drivers/usb/gadget/storage_common.c:283:6: error: ‘CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS’ undeclared (first use in this function) > drivers/usb/gadget/storage_common.c:283:6: note: each undeclared identifier is reported only once for each function it appears in > drivers/usb/gadget/file_storage.c: In function ‘do_set_interface’: > drivers/usb/gadget/file_storage.c:2741:18: error: ‘CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS’ undeclared (first use in this function) > drivers/usb/gadget/file_storage.c: In function ‘handle_exception’: > drivers/usb/gadget/file_storage.c:2891:18: error: ‘CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS’ undeclared (first use in this function) > drivers/usb/gadget/file_storage.c: In function ‘fsg_unbind’: > drivers/usb/gadget/file_storage.c:3154:18: error: ‘CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS’ undeclared (first use in this function) > drivers/usb/gadget/file_storage.c: In function ‘fsg_bind’: > drivers/usb/gadget/file_storage.c:3442:18: error: ‘CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS’ undeclared (first use in this function) > drivers/usb/gadget/file_storage.c: In function ‘fsg_alloc’: > drivers/usb/gadget/file_storage.c:3570:9: error: ‘CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS’ undeclared (first use in this function) > make[2]: *** [drivers/usb/gadget/file_storage.o] Error 1 I just tried running allmodconfig and that is defined: CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS=2 Could it be that you forgot to update your .config before compiling ? CONFIG_USB_GADGET_STORAGE_NUM_BUFFERS is a new Kconfig macro and you must update your .config (maybe make oldconfig is enough ?) before compiling. Here's a snippet of compilation results: $ make -j8 drivers/usb/gadget/ | grep storage CC [M] drivers/usb/gadget/file_storage.o CC [M] drivers/usb/gadget/mass_storage.o LD [M] drivers/usb/gadget/g_file_storage.o LD [M] drivers/usb/gadget/g_mass_storage.o -- balbi
Attachment:
signature.asc
Description: Digital signature
