On Fri, Sep 16, 2011 at 07:21:41PM +0530, ABRAHAM, KISHON VIJAY wrote: > Sergei, > > Thanks for your comments. > > On Fri, Sep 16, 2011 at 3:18 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote: > > Hello. > > > > On 15-09-2011 18:19, Kishon Vijay Abraham I wrote: > > > >> Setting OTG_INTERFSEL to UTMI interferes with charger detection resulting > >> in incorrect detection of charger type. Hence OTG_INTERFSEL is configured > >> to > >> ULPI initially and changed to UTMI only after receiving USB_EVENT_ID or > >> USB_EVENT_VBUS notification. > > > >> Signed-off-by: Kishon Vijay Abraham I<kishon@xxxxxx> > >> Signed-off-by: Balaji T K<balajitk@xxxxxx> > > > > AFAIK, full name is needed here. > > is it not the prerogative of the person giving his signed-off by?? Not really. > >> [sandesh.gowda@xxxxxx: The interface selection has to be done before the > >> PHY > >> is activated and is not allowed to change when the PHY clock is already > >> running] > > > > No signoff from him? > > ok. will add his signoff. You can NOT add someone else's sign-off to a patch, please go re-read Documentation/SubmittingPatches as to what this really means. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
