Re: [PATCH 3/3] usb: ehci: fix comment for EHCI_SHRINK_JIFFIES

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 1 Sep 2011, Ming Lei wrote:

> Hi,
> 
> On Wed, Aug 31, 2011 at 11:07 PM, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
> >> �#define EHCI_SHRINK_JIFFIES �(DIV_ROUND_UP(HZ, 200) + 1)
> >> - � � � � � � � � � � � � � � � � � � � � � � /* 200-ms async qh unlink delay */
> >> + � � � � � � � � � � � � � � � � � � � � � � /* async qh unlink delay */
> >
> > Nice catch! �That "200" was obviously a typo, copying the 200 value
> > from the line above. �Instead of erasing it, how about changing it to
> > say "5" (which is what it should have been)?
> 
> Considered the 5ms is obvious in code, maybe it is not worthy to comment it.

I think it helps; it means that people don't have to figure out in 
their heads that 1 second divided by 200 is equal to 5 ms.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux