Re: [PATCH 3/3] usb: ehci: fix comment for EHCI_SHRINK_JIFFIES

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 31 Aug 2011 tom.leiming@xxxxxxxxx wrote:

> From: Ming Lei <tom.leiming@xxxxxxxxx>
> 
> EHCI_SHRINK_JIFFIES should be 5ms, which was just used originally,
> and not 200ms, so fix it.
> 
> Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
> ---
>  drivers/usb/host/ehci-hcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index f72ae0b..b13fec9 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -95,7 +95,7 @@ static const char	hcd_name [] = "ehci_hcd";
>  #define EHCI_IO_JIFFIES		(HZ/10)		/* io watchdog > irq_thresh */
>  #define EHCI_ASYNC_JIFFIES	(HZ/20)		/* async idle timeout */
>  #define EHCI_SHRINK_JIFFIES	(DIV_ROUND_UP(HZ, 200) + 1)
> -						/* 200-ms async qh unlink delay */
> +						/* async qh unlink delay */

Nice catch!  That "200" was obviously a typo, copying the 200 value
from the line above.  Instead of erasing it, how about changing it to
say "5" (which is what it should have been)?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux