Re: [PATCH] Redundant check in xhci_check_args

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Aug 27, 2011 at 12:37:36AM +0530, sifram rajas wrote:
> In xhci_check_args, the code checks for xhci->devs which is not required.
> This is because the devs member of xhci_hcd is an array of pointers and not
> a
> pointer to a pointer.
> 
> Signed-off-by: Sifram Rajas <sifram.rajas@xxxxxxxxx>
> ---
> diff -uprN a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> --- a/drivers/usb/host/xhci.c 2011-08-17 23:27:16.000000000 +0530
> +++ b/drivers/usb/host/xhci.c 2011-08-22 20:43:34.250000000 +0530
> @@ -945,8 +945,7 @@ static int xhci_check_args(struct usb_hc
>   return -ENODEV;
> 
>   if (check_virt_dev) {
> - if (!udev->slot_id || !xhci->devs
> - || !xhci->devs[udev->slot_id]) {
> + if (!udev->slot_id || !xhci->devs[udev->slot_id]) {

You seem to be missing any leading whitespace now. :(

What mail client are you using?

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux