Re: [PATCH] usbcore: refine warm reset logic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 29 Aug 2011, Andiry Xu wrote:

> On Fri, 2011-08-26 at 11:20 -0400, Alan Stern wrote:
> > uOn Fri, 26 Aug 2011, Andiry Xu wrote:
> > 
> > > > What's wrong with running all the code above for a warm reset?
> > > > 
> > > 
> > > The original warm reset code may reset a port with no connection and
> > 
> > That's strange.  What good does it do to reset a port with no 
> > connection?
> > 
> 
> After double check the device's behavior, I found that I must do so.
> When plug in the buggy device (Kingston DT Ultimate), it reports
> CONNECTION, ENABLE, and link state as Recovery. Then when usbcore
> fetches port status, it reports link state as SS.Inactive with no
> CONNECTION and ENABLE. So driver has to warm reset the port even with no
> connection.

All right.  Please add a comment to the code explaining that some buggy
devices require a warm reset to be issued even when the port appears
not to be connected.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux