Re: [RFC 11/17] usb/ehci: make au1xxx use generic add code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

On 29-08-2011 10:35, ABRAHAM, KISHON VIJAY wrote:

Make au1xxx use generic add code.

Signed-off-by: Sebastian Andrzej Siewior<sebastian@xxxxxxxxxxxxx>
---
  drivers/usb/host/ehci-au1xxx.c |   74 ++++++++++++----------------------------
  1 files changed, 22 insertions(+), 52 deletions(-)

diff --git a/drivers/usb/host/ehci-au1xxx.c b/drivers/usb/host/ehci-au1xxx.c
index 4363fea..43f6ff0 100644
--- a/drivers/usb/host/ehci-au1xxx.c
+++ b/drivers/usb/host/ehci-au1xxx.c
[...]
@@ -146,53 +156,16 @@ static int ehci_hcd_au1xxx_drv_probe(struct platform_device *pdev)
[...]
-
-       ret = usb_add_hcd(hcd, pdev->resource[1].start,
-                         IRQF_DISABLED | IRQF_SHARED);

here the irqflag is set to IRQF_DISABLED | IRQF_SHARED. But your
generic ehci_hcd_plat_add
sets it to IRQF_SHARED always.

   IRQF_DISABLED is deprecated and does nothing -- see <linux/interrupt.h>

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux