On Mon, Aug 29, 2011 at 12:01:31PM +0530, ABRAHAM, KISHON VIJAY wrote: > > + hcd = ehci_hcd_plat_probe(pdev, &ehci_sh_hc_driver); > > + if (IS_ERR(hcd)) { > > + ret = PTR_ERR(hcd); > > goto fail_create_hcd; > > } > > > > - hcd->rsrc_start = res->start; > > - hcd->rsrc_len = resource_size(res); > > - > > - if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, > > - driver->description)) { > > - dev_dbg(&pdev->dev, "controller already in use\n"); > > - ret = -EBUSY; > > - goto fail_request_resource; > > - } > > - > > - hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len); > > - if (hcd->regs == NULL) { > > - dev_dbg(&pdev->dev, "error mapping memory\n"); > > - ret = -ENXIO; > > - goto fail_ioremap; > > - } > > - > > - ret = usb_add_hcd(hcd, irq, IRQF_DISABLED | IRQF_SHARED); > > - if (ret != 0) { > > - dev_err(&pdev->dev, "Failed to add hcd"); > > - goto fail_add_hcd; > > - } > > - > where do you call ehci_hcd_plat_add()? Am I missing something? I call ehci_hcd_plat_probe() which should be ehci_hcd_plat_add(). Fixed up my patch. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html